From 6193e760f10ebdbbea41857ee4113fa8c592c000 Mon Sep 17 00:00:00 2001
From: Jaewon Choi <jaewon.james.choi@gmail.com>
Date: Sun, 5 Nov 2017 17:48:15 +0900
Subject: [PATCH] Fix signal implementation issue

---
 Makefile         | 8 ++++----
 include/signal.h | 4 ++--
 src/signal.c     | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index e09ef55..3571f33 100644
--- a/Makefile
+++ b/Makefile
@@ -1,14 +1,14 @@
 # For implementation
 CC=gcc -std=c99
 CFLAGS=-I./src -I./include
-LIB=
-OBJ=./src/utils.o ./src/commands.o ./src/built_in.o
+LIB=-lpthread
+OBJ=./src/utils.o ./src/commands.o ./src/built_in.o ./src/signal.o
 
 %.o: %.c $(DEPS)
 	$(CC) -c -o $@ $< $(CFLAGS)
 
 mysh: $(OBJ)
-	$(CC) -o $@ $^ ./src/main.c $(CFLAGS)
+	$(CC) -o $@ $^ ./src/main.c $(CFLAGS) $(LIB)
 
 # For testing
 CXX=g++ -std=c++11
@@ -18,7 +18,7 @@ TESTING_SRC=./tests/src/command_parsing_test.cc ./tests/src/command_validate_tes
 TESTING_EXE=mysh-test
 
 test: $(OBJ)
-	$(CXX) $(TESTING_FLAGS) -o $(TESTING_EXE) $(TESTING_SRC) $(OBJ) $(TESTING_LIB)
+	$(CXX) $(TESTING_FLAGS) -o $(TESTING_EXE) $(TESTING_SRC) $(OBJ) $(TESTING_LIB) $(LIB)
 	./$(TESTING_EXE)
 
 clean:
diff --git a/include/signal.h b/include/signal.h
index e255fda..5bcabbe 100644
--- a/include/signal.h
+++ b/include/signal.h
@@ -1,8 +1,8 @@
 #ifndef SIGNAL_H_
 #define SIGNAL_H_
 
-void catch_sigint(int);
+void catch_sigint(int signalNo);
 
-void catch_sigtstp(int);
+void catch_sigtstp(int signalNo);
 
 #endif // SIGNAL_H_
diff --git a/src/signal.c b/src/signal.c
index 10b45ca..e6a785b 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -1,11 +1,11 @@
 #include "signal.h"
 
-void catch_sigint(int)
+void catch_sigint(int signalNo)
 {
   // TODO: File this!
 }
 
-void catch_sigtstp(int);
+void catch_sigtstp(int signalNo)
 {
   // TODO: File this!
 }
-- 
GitLab