code refactoring with service

src/main/java/kr/ajousw/myspringweb/controller/MyWebController.java

@@ -3,6 +3,7 @@ import kr.ajousw.myspringweb.dto.FavoriteMusicRequestDto;
 import kr.ajousw.myspringweb.dto.MusicList;
 import kr.ajousw.myspringweb.entity.FavoriteMusic;
 import kr.ajousw.myspringweb.repository.FavoriteRepository;
+import kr.ajousw.myspringweb.service.MusicService;
 
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.client.RestTemplate;
@@ -21,74 +22,33 @@ import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestParam;
 
 
+
 @RestController
 public class MyWebController {
 
     @Autowired
-    FavoriteRepository albumsRepo;
-
-    @GetMapping(value="/musicSearch/{term}")
-    public MusicList musicSearchByPath(@PathVariable String term) {
-
-        //클래스 변수로 정의
-        RestTemplate restTemplate = new RestTemplate();
-        
-        // 아래 코드는 클래스 메쏘드에 작성 – GetMapping 부분에 구현
-        // 아래 코드에서 url은 “itunes url”
-        try {
-            String url = "https://itunes.apple.com/search?term="+term+"&entity=album";
-            String response = restTemplate.getForObject(url, String.class);
-            ObjectMapper mapper = new ObjectMapper();
-            MusicList list = mapper.readValue(response, MusicList.class);
-            System.out.println(list.getResultCount());
-            return list;
+    MusicService service;
 
-        } catch(IOException e) {
-            System.out.println(e.toString());
-            return null;
-        }
+    @GetMapping(value="/musicSearch/{name}")
+    public MusicList musicSearchByPath(@PathVariable String name) 
+    {
+        return service.searchMusic(name);
     }
 
     @GetMapping(value="/musicSearch")
-    public MusicList musicSearchByParam(@RequestParam String term){
-
-        RestTemplate restTemplate = new RestTemplate();
-        
-        try {
-            String url = "https://itunes.apple.com/search?term="+term+"&entity=album";
-            String response = restTemplate.getForObject(url, String.class);
-            ObjectMapper mapper = new ObjectMapper();
-            MusicList list = mapper.readValue(response, MusicList.class);
-            System.out.println(list.getResultCount());
-            return list;
-
-        } catch(IOException e) {
-            System.out.println(e.toString());
-            return null;
-        }
+    public MusicList musicSearchByParam(@RequestParam(value ="term") String name)
+    {
+        return service.searchMusic(name);
     }
 
-    //Get Favorite Music list from Database
-    @GetMapping(value="/likes")
+
+    @GetMapping(value="/likes") //Get Favorite Music list from Database
     public List<FavoriteMusic> getLikes() {
-        try {
-            return albumsRepo.findAll();
-        } catch (Exception e) {
-            System.out.println(e.toString());
-        return null;
-        }
+        return service.getLikes();
     }
 
     @PostMapping(value="/likes")
-    @Transactional
-    public int postLikes(@RequestBody FavoriteMusicRequestDto favorite)
-    {
-        FavoriteMusic music = albumsRepo.save(favorite.toEntity());
-        if(music != null) {
-            return 1;
-        }
-        else {
-            return 0;
-        }
+    public int postLikes(@RequestBody FavoriteMusicRequestDto favorite) {
+        return service.saveFavorite(favorite);
     }
 }
\ No newline at end of file

src/main/java/kr/ajousw/myspringweb/service/MusicService.java

+package kr.ajousw.myspringweb.service;
+import kr.ajousw.myspringweb.dto.FavoriteMusicRequestDto;
+import kr.ajousw.myspringweb.dto.MusicList;
+import kr.ajousw.myspringweb.entity.FavoriteMusic;
+import kr.ajousw.myspringweb.repository.FavoriteRepository;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.PathVariable;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.client.RestTemplate;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import jakarta.transaction.Transactional;
+import lombok.RequiredArgsConstructor;
+
+@Service
+@Transactional
+@RequiredArgsConstructor
+
+public class MusicService {
+    private final FavoriteRepository albumsRepo;
+    RestTemplate restTemplate = new RestTemplate();
+
+    public MusicList searchMusic(@PathVariable String term) {
+        try {
+            String url = String.format("https://itunes.apple.com/search?term=%s&entity=album", term);
+            String response = restTemplate.getForObject(url, String.class);
+            ObjectMapper mapper = new ObjectMapper();
+            MusicList list = mapper.readValue(response, MusicList.class);
+            System.out.println(list.getResultCount());
+
+            return list;
+            
+        } catch (IOException e) {
+            System.out.println(e.toString());
+            return null;
+        }
+
+    }
+
+    @GetMapping(value="/likes")
+    public List<FavoriteMusic> getLikes() {
+
+        try {
+            return albumsRepo.findAll();
+
+        } catch (Exception e) {
+            System.out.println(e.toString());
+            return null;
+            
+        }
+    }
+
+    public int saveFavorite(@RequestBody FavoriteMusicRequestDto favorite){
+        FavoriteMusic music = albumsRepo.save(favorite.toEntity());
+
+        if(music != null) {
+            return 1;
+        }
+        else {
+            return 0;
+        }
+    }
+
+
+
+}
\ No newline at end of file