code refactoring with service

src/main/java/kr/ajousw/myspringweb/controller/MyWebController.java

@@ -19,68 +19,34 @@ import kr.ajousw.myspringweb.dto.FavoriteMusicRequestDto;
 import kr.ajousw.myspringweb.dto.MusicList;
 import kr.ajousw.myspringweb.entity.FavoriteMusic;
 import kr.ajousw.myspringweb.repository.FavoriteRepository;
+import kr.ajousw.myspringweb.service.MusicService;
 
 @RestController
 public class MyWebController {
     @Autowired
-    FavoriteRepository albumsRepo;
+    MusicService service;
 
-    @GetMapping("/musicSearch/{term}")
-    public MusicList musicSearchByPath(@PathVariable String term) {
-        RestTemplate restTemplate = new RestTemplate();
-
-        try {
-            String response = restTemplate
-                    .getForObject("https://itunes.apple.com/search?term=" + term + "&entity=album", String.class);
-            ObjectMapper mapper = new ObjectMapper();
-            MusicList list = mapper.readValue(response, MusicList.class);
-            System.out.println(list.getResultCount());
-            return list;
-        } catch (IOException e) {
-            System.out.println(e.toString());
-            return null;
-        }
+    @GetMapping("/musicSearch/{name}")
+    public MusicList musicSearchByPath(@PathVariable String name) {
+        return service.searchMusic(name);
 
     }
 
     @GetMapping("/musicSearch")
-    public MusicList musicSearchByParam(@RequestParam String term) {
-        RestTemplate restTemplate = new RestTemplate();
+    public MusicList musicSearchByParam(@RequestParam String name) {
+        return service.searchMusic(name);
        
-        try {
-            String response = restTemplate
-                    .getForObject("https://itunes.apple.com/search?term=" + term + "&entity=album", String.class);
-            ObjectMapper mapper = new ObjectMapper();
-            MusicList list = mapper.readValue(response, MusicList.class);
-            System.out.println(list.getResultCount());
-            return list;
-        } catch (IOException e) {
-            System.out.println(e.toString());
-            return null;
-        }
     }
 
     @GetMapping(value = "/likes")
     public List<FavoriteMusic> getLikes() {
-
-        try {
-            return albumsRepo.findAll();
-
-        } catch (Exception e) {
-            System.out.println(e.toString());
-            return null;
-        }
+        return service.getLikes();
     }
 
     @PostMapping(value = "/likes")
     @Transactional
     public int postLikes(@RequestBody FavoriteMusicRequestDto favorite) {
-        FavoriteMusic music = albumsRepo.save(favorite.toEntity());
-        if (music != null) {
-            return 1;
-        } else {
-            return 0;
-        }
+        return service.saveFavorite(favorite);
     }
 
 }

src/main/java/kr/ajousw/myspringweb/service/MusicService.java

+package kr.ajousw.myspringweb.service;
+
+import java.io.IOException;
+import java.util.List;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+import org.springframework.web.client.RestTemplate;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import jakarta.transaction.Transactional;
+import kr.ajousw.myspringweb.dto.FavoriteMusicRequestDto;
+import kr.ajousw.myspringweb.dto.MusicList;
+import kr.ajousw.myspringweb.entity.FavoriteMusic;
+import kr.ajousw.myspringweb.repository.FavoriteRepository;
+import lombok.RequiredArgsConstructor;
+
+@Service
+@Transactional
+@RequiredArgsConstructor
+public class MusicService {
+    
+    private final FavoriteRepository albumsRepo;
+   
+    RestTemplate restTemplate = new RestTemplate();
+
+    public MusicList searchMusic(String name) {
+        try {
+            String response = restTemplate
+                    .getForObject("https://itunes.apple.com/search?term=" + name + "&entity=album", String.class);
+            ObjectMapper mapper = new ObjectMapper();
+            MusicList list = mapper.readValue(response, MusicList.class);
+            System.out.println(list.getResultCount());
+            return list;
+        } catch (IOException e) {
+            System.out.println(e.toString());
+            return null;
+        }
+    }
+
+    public List<FavoriteMusic> getLikes() {
+        try {
+            return albumsRepo.findAll();
+
+        } catch (Exception e) {
+            System.out.println(e.toString());
+            return null;
+        }
+    }
+
+    public int saveFavorite(FavoriteMusicRequestDto favorite){
+        FavoriteMusic music = albumsRepo.save(favorite.toEntity());
+        if (music != null) {
+            return 1;
+        } else {
+            return 0;
+        }
+    }
+}